Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kn): Enable faas to be integrated as plugin to kn #155

Merged
merged 1 commit into from
Oct 8, 2020
Merged

feat(kn): Enable faas to be integrated as plugin to kn #155

merged 1 commit into from
Oct 8, 2020

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Oct 6, 2020

Changes:

  • Add plugin package to enable faas to be consumed as plugin
  • Fix cyclic dependency issue on pkg/kn/root package
  • Optional: changed output to display standard output of service create command
    • I'll understand if it isn't desired or needs further discussion :)

Example:

➜  test-project kn faas deploy             
Creating service 'test--project' in namespace 'default':

  0.036s The Configuration is still working to reflect the latest desired specification.
  0.059s The Route is still working to reflect the latest desired specification.
  0.109s Configuration "test--project" is waiting for a Revision to become ready.
 10.192s ...
 10.221s Ingress has not yet been reconciled.
 10.273s Waiting for load balancer to be ready
 10.884s Ready to serve.

Service 'test--project' created to latest revision 'test--project-dfwml-1' is available at URL:
http://test--project.default.example.com

@dsimansk dsimansk requested review from rhuss and a team October 6, 2020 17:46
lance
lance approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

knative/deployer.go Outdated Show resolved Hide resolved
@zroubalik
Copy link
Contributor

@dsimansk #152 was merged, so you can proceed with the rebase

@dsimansk dsimansk force-pushed the faas-kn-integration branch from 410a333 to df1819b Compare October 7, 2020 17:24
@dsimansk
Copy link
Contributor Author

dsimansk commented Oct 7, 2020

@dsimansk #152 was merged, so you can proceed with the rebase

Rebased.

It seems to work fine in kn so far. Great work @zroubalik!

@lance
Copy link
Member

lance commented Oct 7, 2020

@dsimansk can you point to docs (or describe here) what steps I should take to test this in kn?

@dsimansk
Copy link
Contributor Author

dsimansk commented Oct 8, 2020 •
edited
Loading

I can describe here and eventually create some doc later.

Here is my WIP branch (it seems messy currently): https://github.com/dsimansk/client/tree/release-0.17-with-faas

The main changes needed:

➜  client git:(release-0.17-with-faas) kn faas --help
Function as a Service

Create and run Functions as a Service.

Usage:
  faas [command]

Available Commands:
  build       Build an existing Function project as an OCI image
  completion  Generate bash/zsh completion scripts
  create      Create a new Function, including initialization of local files and deployment
  delete      Delete a Function deployment
  deploy      Deploy an existing Function project to a cluster
  describe    Describes the Function
  help        Help about any command
  init        Initialize a new Function project
  list        Lists deployed Functions
  run         Runs the Function locally
  version     Print version.  With --verbose the build date stamp and commit hash are included if available.

Flags:
  -h, --help      help for faas
  -v, --verbose   print verbose logs

Use "faas [command] --help" for more information about a command.

@zroubalik
Copy link
Contributor

@lance ok to merge this?

@lance
Copy link
Member

lance commented Oct 8, 2020

@zroubalik sure thing.

@lance lance merged commit 85a5f47 into knative:main Oct 8, 2020
@zroubalik zroubalik mentioned this pull request Oct 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

@rhuss rhuss Awaiting requested review from rhuss

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsimansk @zroubalik @lance